add basic auth #49
Merged
add basic auth #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penghuo
requested review from
dai-chen,
rupal-bq,
vamsimanohar and
anirudha
as code owners
Signed-off-by: Peng Huo <[email protected]>
penghuo
force-pushed
the
featureBasicAuth
branch
from
08cfbdb to
d6ce91e
Compare
dai-chen
approved these changes
Sep 27, 2023
docs/index.md
Outdated
| @@ -271,7 +271,9 @@ In the index mapping, the `_meta` and `properties`field stores meta and schema i | |||
| - `spark.datasource.flint.host`: default is localhost. | |||
| - `spark.datasource.flint.port`: default is 9200. | |||
| - `spark.datasource.flint.scheme`: default is http. valid values [http, https] | |||
| - `spark.datasource.flint.auth`: default is false. valid values [false, sigv4] | |||
| - `spark.datasource.flint.auth`: default is false. valid values [false, sigv4, basic] | |||
There was a problem hiding this comment.
Hey can we change default to noauth. It seems confusing default looks like boolean and others are strings.
I will also change at my end.
There was a problem hiding this comment.
make sense, change to
`spark.datasource.flint.auth`: default is noauth. valid values [noauth, sigv4, basic]
Signed-off-by: Peng Huo <[email protected]>
vamsimanohar
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#46
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.